Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parsl to 2025.1.6 #1759

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Update Parsl to 2025.1.6 #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog.d/20250109_115759_kevin_update_parsl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Changed
^^^^^^^

- Update Parsl to `2025.1.6 <https://pypi.org/project/parsl/2025.1.6/>`_. Note
that Parsl's Channels were deprecated in Aug, 2024, and now completely
removed (see `Parsl Issue #3515
<https://github.com/Parsl/parsl/issues/3515>`_); consequently, this will be a
breaking change for those using Parsl's Channels.
9 changes: 0 additions & 9 deletions compute_endpoint/globus_compute_endpoint/endpoint/config/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
from globus_compute_endpoint import engines, strategies
from globus_compute_endpoint.endpoint.config.pam import PamConfiguration
from parsl import addresses as parsl_addresses
from parsl import channels as parsl_channels
from parsl import launchers as parsl_launchers
from parsl import providers as parsl_providers

Expand Down Expand Up @@ -66,19 +65,11 @@ class LauncherModel(BaseConfigModel):
_validate_type = _validate_import("type", parsl_launchers)


class ChannelModel(BaseConfigModel):
type: str

_validate_type = _validate_import("type", parsl_channels)


class ProviderModel(BaseConfigModel):
type: str
channel: t.Optional[ChannelModel]
launcher: t.Optional[LauncherModel]

_validate_type = _validate_import("type", parsl_providers)
_validate_channel = _validate_params("channel")
_validate_launcher = _validate_params("launcher")


Expand Down
6 changes: 0 additions & 6 deletions compute_endpoint/globus_compute_endpoint/engines/globus_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,12 +253,6 @@ def start(
f"Containerized launch cmd template: {self.executor.launch_cmd}"
)

if (
getattr(self.executor.provider, "channel", None)
and not self.executor.provider.channel.script_dir
):
self.executor.provider.channel.script_dir = script_dir

os.makedirs(self.executor.provider.script_dir, exist_ok=True)
if results_passthrough:
# Only update the default queue in GCExecutorBase if
Expand Down
2 changes: 1 addition & 1 deletion compute_endpoint/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
# 'parsl' is a core requirement of the globus-compute-endpoint, essential to a range
# of different features and functions
# pin exact versions because it does not use semver
"parsl==2024.11.25",
"parsl==2025.1.6",
"pika>=1.2.0",
"pyprctl<0.2.0",
"setproctitle>=1.3.2,<1.4",
Expand Down
Loading