Shutdown engines in test #1758
Merged
Shutdown engines in test #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing `.shutdown()` in a test engine factory. The comment was correct that the _executor_ was not started, but either missed that the status reporting thread was started, or the rug was changed underneath it.
khk-globus
added
no-news-is-good-news
chris-janidlo
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing
.shutdown()in a test engine factory. The comment was correct that the executor was not started, but either missed that the status reporting thread was started, or the rug was changed underneath it.Not sure if this will address all of what we're seeing in CI, but this was a repeat offender that I was finally able to recreate locally. At the very least, it should help reduce the noise if/when other tests fail.
Type of change