Modify release script to distinguish git tag errors #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiGlobus
added
no-news-is-good-news
khk-globus
reviewed
Dec 6, 2024
LeiGlobus
force-pushed
the
git-tag-error
branch
from
27486d5 to
885c2e5
Compare
khk-globus
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I released 2.32.0 earlier this week, the git tag command in release.sh failed(my gpg key, only used for tags, expired a few weeks earlier), but I missed the error message amongst the release output:
The script thinks it's a 'tag already exists' error and asks to confirm, which I answered 'y' without becoming suspicious of why the tag would already be pre-existing. In the end, the packages were released but the tag wasn't pushed.
Instead, the user should be prompted for 'already exists' situations, but the script should abort for other, unknown issues.