Release v2.31.0 #1727
Merged
Release v2.31.0 #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-janidlo
added
the
no-news-is-good-news
LeiGlobus
reviewed
Nov 18, 2024
chris-janidlo
force-pushed
the
v2.31.0
branch
from
6982d4e to
84a4867
Compare
During testing, it was discovered that the following error happens when
starting an endpoint on py313. Pulling support for that version until a
future release while diagnosing the error.
```
Traceback (most recent call last):
File "/Users/chris/opt/anaconda3/envs/gce-py313/bin/globus-compute-endpoint", line 8, in <module>
sys.exit(cli_run())
~~~~~~~^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/cli.py", line 984, in cli_run
app()
~~~^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
~~~~~~~~~^^^^^^^^^^^^^^^^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/exception_handling.py", line 80, in wrapper
return f(*args, **kwargs)
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/cli.py", line 468, in start_endpoint
_do_start_endpoint(
~~~~~~~~~~~~~~~~~~^
ep_dir=ep_dir,
^^^^^^^^^^^^^^
endpoint_uuid=state.endpoint_uuid,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
die_with_parent=state.die_with_parent,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/cli.py", line 693, in _do_start_endpoint
get_cli_endpoint(ep_config).start_endpoint(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
ep_dir,
^^^^^^^
...<5 lines>...
die_with_parent,
^^^^^^^^^^^^^^^^
)
^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/endpoint/endpoint.py", line 559, in start_endpoint
Endpoint.daemon_launch(
~~~~~~~~~~~~~~~~~~~~~~^
endpoint_uuid,
^^^^^^^^^^^^^^
...<4 lines>...
parent_pid,
^^^^^^^^^^^
)
^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/endpoint/endpoint.py", line 589, in daemon_launch
interchange.start()
~~~~~~~~~~~~~~~~~^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/endpoint/interchange.py", line 218, in start
self.start_engine()
~~~~~~~~~~~~~~~~~^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/endpoint/interchange.py", line 141, in start_engine
self.executor.start(
~~~~~~~~~~~~~~~~~~~^
results_passthrough=self.results_passthrough,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
endpoint_id=self.endpoint_id,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
run_dir=self.logdir,
^^^^^^^^^^^^^^^^^^^^
)
^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/engines/globus_compute.py", line 268, in start
self._status_report_thread.start()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/site-packages/globus_compute_endpoint/engines/base.py", line 52, in start
self._thread.start()
~~~~~~~~~~~~~~~~~~^^
File "/Users/chris/opt/anaconda3/envs/gce-py313/lib/python3.13/threading.py", line 973, in start
_start_joinable_thread(self._bootstrap, handle=self._handle,
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
daemon=self.daemon)
^^^^^^^^^^^^^^^^^^^
RuntimeError: thread already started
```
chris-janidlo
force-pushed
the
v2.31.0
branch
from
3e0f767 to
c0464c3
Compare
LeiGlobus
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.