Simplify command ACK #1370
Merged
Simplify command ACK #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
no-news-is-good-news
khk-globus
requested review from
yadudoc,
ryanchard,
chris-janidlo,
rjmello and
LeiGlobus
For the time being, YAGNI, and recognize that we never do anything different; we *always* ACK the message, regardless of the processing outcome. No need to worry about "proper handling" later, if it's already done.
khk-globus
force-pushed
the
simplify_ack
branch
from
dd6486b to
c176483
Compare
rjmello
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the time being, YAGNI, and recognize that we never do anything different; we always ACK the message, regardless of the processing outcome. No need to worry about "proper handling" later, if it's already done.
Type of change