Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass address to Parsl HTEX via kwargs catch-all #1363

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Pass address to Parsl HTEX via kwargs catch-all #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions compute_endpoint/globus_compute_endpoint/engines/globus_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@ def __init__(
self,
*args,
label: str = "GlobusComputeEngine",
address: t.Optional[str] = None,
strategy: t.Optional[SimpleStrategy] = SimpleStrategy(),
executor: t.Optional[HighThroughputExecutor] = None,
**kwargs,
):
self.address = address
self.run_dir = os.getcwd()
self.label = label
self._status_report_thread = ReportingThread(target=self.report_status, args=[])
Expand All @@ -38,10 +36,7 @@ def __init__(
self.max_workers_per_node = 1
if executor is None:
executor = HighThroughputExecutor( # type: ignore
*args,
label=label,
address=address,
**kwargs,
*args, label=label, **kwargs
)
self.executor = executor

Expand Down
12 changes: 2 additions & 10 deletions compute_endpoint/globus_compute_endpoint/engines/process_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,12 @@


class ProcessPoolEngine(GlobusComputeEngineBase):
def __init__(
self,
*args,
label: str = "ProcessPoolEngine",
**kwargs,
):
def __init__(self, *args, label: str = "ProcessPoolEngine", **kwargs):
self.label = label
self.executor: t.Optional[NativeExecutor] = None
self._executor_args = args
self._executor_kwargs = kwargs
self._status_report_thread = ReportingThread(
target=self.report_status,
args=[],
)
self._status_report_thread = ReportingThread(target=self.report_status, args=[])
super().__init__(*args, **kwargs)

def start(
Expand Down
12 changes: 2 additions & 10 deletions compute_endpoint/globus_compute_endpoint/engines/thread_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,10 @@


class ThreadPoolEngine(GlobusComputeEngineBase):
def __init__(
self,
*args,
label: str = "ThreadPoolEngine",
**kwargs,
):
def __init__(self, *args, label: str = "ThreadPoolEngine", **kwargs):
self.label = label
self.executor = NativeExecutor(*args, **kwargs)
self._status_report_thread = ReportingThread(
target=self.report_status,
args=[],
)
self._status_report_thread = ReportingThread(target=self.report_status, args=[])
super().__init__(*args, **kwargs)

def start(
Expand Down