Separate heartbeat_periods and reporting_period #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmello
requested changes
Nov 8, 2023
There was a problem hiding this comment.
We'll also need to update the engine_runner fixture and the status report tests.
compute_endpoint/globus_compute_endpoint/engines/globus_compute.py
Outdated
Show resolved
Hide resolved
yadudoc
force-pushed
the
heartbeats_and_reporting_sc_28343
branch
from
7217414 to
eb6f4fb
Compare
…, and ThreadPoolEngine
yadudoc
force-pushed
the
heartbeats_and_reporting_sc_28343
branch
2 times, most recently
from
d7ad2c6 to
64ae4ed
Compare
* Test fixes * Removing heartbeat params from engine init * Minor perf improvements
yadudoc
force-pushed
the
heartbeats_and_reporting_sc_28343
branch
from
64ae4ed to
d2ca73f
Compare
|
[sc-28343] |
|
This pull request has been linked to Shortcut Story #28343: Separate engine heartbeats and endpoint status reporting periods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
GlobusComputeEnginehas a notion ofhearbeat_periodandheartbeat_thresholdused internally to track worker liveness. This is separate from the status reporting logic implemented in theGlobusComputeEngineBasethat sendsEPStatusReports.This PR sets the
reporting periodto a constant. Users should not be able to tweak this, and we should not be supporting cases where there's any functionality built on faster updates.Fixes # (issue)
Type of change
Choose which options apply, and delete the ones which do not apply.