Handle unrecognized errors in guest create #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`globus gcs collection create guest` previously assumed that the shape of an error from GCS met its expectations that `detail` would be dict data. However, GCS docs do not guarantee this -- `detail` can be of any type. Therefore, the inspection should explicitly check for this and fail if the field is present with an unexpected type. Failure to do so resulted in a `get()` call on a non-dict object. Resolves globus#928
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globus gcs collection create guestpreviously assumed that the shapeof an error from GCS met its expectations that
detailwould be dictdata. However, GCS docs do not guarantee this --
detailcan be ofany type. Therefore, the inspection should explicitly check for this
and fail if the field is present with an unexpected type.
Failure to do so resulted in a
get()call on a non-dict object.Resolves #928