Tighten mypy: globus_cli.parsing #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't use a subclass of GlobusCommand for env var checking (not necessary) - Remove the opt-out capability for env var checking (never used) - Remove the capability for custom class usage (also never used)
- tighten the mypy checking criteria - for simpler type semantics, remove use of `functools.partial`
- disallow_untyped_defs=false in mypy config - remove use of functools.partial (never used)
Tighten mypy and remove use of functools.partial (simplify).
rm config for a module which no longer exists.
rm config for a module which no longer exists
sirosen
requested review from
ada-globus,
derek-globus,
kurtmckee and
aaschaer
as code owners
kurtmckee
requested changes
Dec 20, 2023
Co-authored-by: Kurt McKee <[email protected]>
|
Build is failing; I though I saw a deleted |
|
It turned out to be a different module needing deferred annotations. One of these days, I'll finally learn my lesson and go back to running |
kurtmckee
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step by step, get the entire subpackage checked strictly under mypy.