Rename Timers "jobs" to simply "timers" #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtmckee
requested review from
ada-globus,
derek-globus,
sirosen and
aaschaer
as code owners
sirosen
requested changes
Dec 12, 2023
ada-globus
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
I've got a slight uneasiness about a little confusion between jobs and timers from an internal POV (i.e., internal naming) since things like "job_id" are referring to the specific key in the response and/or route they're interacting with. But I am super enthusiastic about the changes to the customer-facing messaging, and am not going to let my very modest reservation hold up what is overall a super positive change!
kurtmckee
force-pushed
the
rename-timer-jobs
branch
from
9d7ccf9 to
1dacf4e
Compare
kurtmckee
force-pushed
the
rename-timer-jobs
branch
from
1dacf4e to
a1ae4e5
Compare
sirosen
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other
This results in output at the CLI that shows the term "Timer ID" instead of "Job ID", for example.