Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client id as identity id if cli is invoked with client creds #912

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Use client id as identity id if cli is invoked with client creds #912

merged 1 commit into from
Dec 8, 2023

Conversation

derek-globus
Copy link
Contributor

What?

  • Commands which attempt to infer the identity of the user running the command will now
    correctly use the client_id for confidential client based invocation patterns.

Testing

  • Invoked globus collection create guest ... with confidential client parameters got past previous erroring point.

@derek-globus derek-globus merged commit fe5b9e6 into globus:main Dec 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtmckee kurtmckee kurtmckee approved these changes

@ada-globus ada-globus Awaiting requested review from ada-globus ada-globus is a code owner

@sirosen sirosen Awaiting requested review from sirosen sirosen is a code owner

@aaschaer aaschaer Awaiting requested review from aaschaer aaschaer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derek-globus @kurtmckee