Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all references to the tutorial endpoints #907

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Replace all references to the tutorial endpoints #907

merged 1 commit into from
Dec 7, 2023

Conversation

ada-globus
Copy link
Contributor

image

kurtmckee
kurtmckee approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but part of me is thinking that it would be nice to make these start with 11111111- and 22222222- so that it's a little more guessable that these are bogus.

@ada-globus
Copy link
Contributor Author

I approve, but part of me is thinking that it would be nice to make these start with 11111111- and 22222222- so that it's a little more guessable that these are bogus.

But isn't it easy to see at a glance to determine that these are simply str(uuid.uuid5(uuid.UUID(int=0), "foo")) 😉

@ada-globus ada-globus merged commit 3ee3507 into main Dec 7, 2023
36 checks passed
@ada-globus ada-globus deleted the an/remove-tutorial-endpoints branch December 7, 2023 23:38
@kurtmckee
Copy link
Member

kurtmckee commented Dec 7, 2023 •
edited
Loading

Ah, I wondered whether bit 17 was flipped by coincidence or not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirosen sirosen sirosen approved these changes

@kurtmckee kurtmckee kurtmckee approved these changes

@derek-globus derek-globus Awaiting requested review from derek-globus derek-globus is a code owner

@aaschaer aaschaer Awaiting requested review from aaschaer aaschaer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ada-globus @kurtmckee @sirosen