-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
globus api --scope-string (for clients) #906
Conversation
c2f6757
to
aadb0f4
Compare
src/globus_cli/commands/api.py
Outdated
"A scope string to consent to for this command (only supported for " | ||
"confidential client usage). " | ||
"Pass this option multiple times to specify multiple scopes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommending removal of "for this command". I've rewrapped the lines as well.
"A scope string to consent to for this command (only supported for " | |
"confidential client usage). " | |
"Pass this option multiple times to specify multiple scopes." | |
"A scope string to consent to " | |
"(only supported for confidential client usage). " | |
"Pass this option multiple times to specify multiple scopes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this based on the standup conversation yesterday around "we'll keep using this cached token which now has expanded consents"? Or is this more of just trying to make it read cleaner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only about readability -- "to consent to for" caught my eye.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question/refactoring option, but I like how tightly this is scoped.
Because it passes through the existing login manager mechanisms, I have fewer concerns about impact, upon review, than I voiced in earlier discussions.
What?
The
globus api <service>
command now supports a--scope-string
parameter.If supplied, the CLI will enforce that any specified scope strings are included
in consent requirements in addition to standard service scope requirements.
This parameter may be supplied multiple times to specify multiple scope strings.
This parameter is only supported in the context of Client Credentials-based authentication.
(Client Credentials with GLOBUS_CLI_CLIENT_ID)
Why?
Provide users a path to interact with APIs not currently supported in the CLI which require specific scope consents (ie. auth's project management apis)
Testing