add support for entity type filtering on endpoint search #1055
Conversation
pjhinton-globus
force-pushed
the
pjhinton/sc-29242-endpoint-search-filter-entity-type
branch
2 times, most recently
from
aa12186 to
0a71c12
Compare
|
Once the Globus SDK version in |
pjhinton-globus
force-pushed
the
pjhinton/sc-29242-endpoint-search-filter-entity-type
branch
from
0a71c12 to
cfa3ccf
Compare
It appears that the version of the Globus SDK in |
pjhinton-globus
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1,
MaxTueckeGlobus and
sirosen
as code owners
pjhinton-globus
force-pushed
the
pjhinton/sc-29242-endpoint-search-filter-entity-type
branch
2 times, most recently
from
ffdd589 to
a7a61e5
Compare
There was a problem hiding this comment.
Initially, I was going to recommend that this change include a new test, but I now see that we don't have tests which exercise this command.
The ideal would be that there are already tests for endpoint search which demonstrate how to test this, and I could point you at an appropriate one to work off of as a template. But we're missing that bit of framework, and I don't think it's fair to ask you to set that up as part of a first contribution.
I'm taking testing as a follow-up item. I have a specific plan for how to test such an addition, and I'll @-mention you on that when I have it up, so you can see what a test would look like.
Can you give this a quick rebase to get passing CI, and optionally apply my suggestion to put backticks in place? That will put this in a clean-to-merge state.
| @@ -0,0 +1,3 @@ | |||
| ### Enhancements | |||
|
|
|||
| * Added a --filter-entity-type option on endpoint search. | |||
There was a problem hiding this comment.
| * Added a --filter-entity-type option on endpoint search. | |
| * Added a `--filter-entity-type` option on endpoint search. |
Small tweak. Since this renders on the doc site it's nice to give code-style.
Implements requested change from @sirosen, adding formatting to the command line option cited in the changelog fragment. globus#1055 (comment)
Add new command line option to globus endpoint search which limits the returned values to certain types of collections. Make use of change to Python SDK work in 37389. refs sc-29242 add formatting for option in changelog Implements requested change from @sirosen, adding formatting to the command line option cited in the changelog fragment. globus#1055 (comment)
pjhinton-globus
force-pushed
the
pjhinton/sc-29242-endpoint-search-filter-entity-type
branch
from
b066a0c to
63d104a
Compare
|
@sirosen wrote:
Done! Let me know if any other adjustments need to be made. Thanks again! |
pjhinton-globus
deleted the
pjhinton/sc-29242-endpoint-search-filter-entity-type
branch
Add new command line option to globus endpoint search which limits the returned values to certain types of collections. Make use of change to Python SDK work in 37389. refs sc-29242 add formatting for option in changelog Implements requested change from @sirosen, adding formatting to the command line option cited in the changelog fragment. globus#1055 (comment)
Add new command line option to globus endpoint search which limits the returned values to certain types of collections. Make use of change to Python SDK work in 37389.
refs sc-29242