Skip to content

Commit

Permalink
Update SDK version and fix mypy failures
Browse files Browse the repository at this point in the history
Updating our runtime version also updates the version we use for
type-checking.
  • Loading branch information
sirosen committed Oct 27, 2023
1 parent 2d7a667 commit 5ba744b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def read_readme():
package_dir={"": "src"},
python_requires=">=3.7",
install_requires=[
"globus-sdk==3.28.0",
"globus-sdk==3.30.0",
"click>=8.1.4,<9",
"jmespath==1.0.1",
"packaging>=17.0",
Expand Down
4 changes: 3 additions & 1 deletion src/globus_cli/login_manager/_old_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ def _get_client_creds(conf: ConfigParser) -> tuple[str, str] | None:
return None


def invalidate_old_config(auth_client: globus_sdk.AuthClient) -> None:
def invalidate_old_config(
auth_client: globus_sdk.ConfidentialAppAuthClient | globus_sdk.NativeAppAuthClient,
) -> None:
# revoke any old config-stored tokens (logout)
# and delete old client creds
conf = _old_conf_parser()
Expand Down
5 changes: 4 additions & 1 deletion src/globus_cli/login_manager/auth_flows.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ def do_local_server_auth_flow(
return True


def exchange_code_and_store(auth_client: globus_sdk.AuthClient, auth_code: str) -> None:
def exchange_code_and_store(
auth_client: globus_sdk.ConfidentialAppAuthClient | globus_sdk.NativeAppAuthClient,
auth_code: str,
) -> None:
"""
Finishes auth flow after code is gotten from command line or local server.
Exchanges code for tokens and stores them.
Expand Down

0 comments on commit 5ba744b

Please sign in to comment.