Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-275: add tests for glass.lensing #454

Merged
merged 10 commits into from
Jan 23, 2025
Merged

gh-275: add tests for glass.lensing #454

merged 10 commits into from
Jan 23, 2025

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Nov 25, 2024

Closes #275. Adds tests for the glass.shells module. Coverage going up - 88.9%.

Worked on this before the pause. Can't remember where I got to, but makes sense to merge. We can always improve the tests later.

@paddyroddy paddyroddy added enhancement New feature or request testing Work is related to testing labels Nov 25, 2024
@paddyroddy paddyroddy self-assigned this Nov 25, 2024
@paddyroddy paddyroddy marked this pull request as ready for review January 23, 2025 13:48
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @paddyroddy! 🚀

@paddyroddy paddyroddy merged commit 3b7d01e into main Jan 23, 2025
21 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-275 branch January 23, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Work is related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/review tests for glass.lensing
2 participants