Uses actual exec path as editor command #4009
Open
+39
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The interactive rebase is a native git feature that uses code or another similar target as an editor. If the editor is portable or there is no env path to the editor for some other reason, then git can not open it. To fix it we can use direct app path that can be resolved from
vscode.env.appRoot
and some minor redirection tobin/code
.For windows and linux it's solved by
../../bin/code
For MacOS -
./bin/code
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses