Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses actual exec path as editor command #4009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Feb 3, 2025

Description

The interactive rebase is a native git feature that uses code or another similar target as an editor. If the editor is portable or there is no env path to the editor for some other reason, then git can not open it. To fix it we can use direct app path that can be resolved from vscode.env.appRoot and some minor redirection to bin/code.

For windows and linux it's solved by ../../bin/code
For MacOS - ./bin/code

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Feb 3, 2025 that may be closed by this pull request
@nzaytsev nzaytsev requested review from eamodio and d13 February 3, 2025 07:49
src/system/-webview/vscode.ts Dismissed Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive rebase doesn't work in GL without VS Code added to path
1 participant