Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use explicit image name for release #250

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Jan 5, 2025

we can regex it later

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

we can regex it later

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth self-assigned this Jan 5, 2025
@Copilot Copilot bot review requested due to automatic review settings January 5, 2025 21:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@github-actions github-actions bot added the fix label Jan 5, 2025
@jmeridth jmeridth merged commit 325ab60 into main Jan 5, 2025
30 checks passed
@jmeridth jmeridth deleted the jm_no_fancy_image_name branch January 5, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant