Skip to content

Commit

Permalink
chore: add pull_request_target for releases
Browse files Browse the repository at this point in the history
- [x] add pull_request_target to release GitHub Action so we have access to fork PR labels

I am not worried about the security implications with us checking out the forked pull requests code. This action only fires after a merge to main so this means the pull request code has been reviewed by a maintainer. We are post-CI/code run.

Signed-off-by: jmeridth <[email protected]>
  • Loading branch information
jmeridth committed May 21, 2024
1 parent 21198ba commit 67b0908
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
- closed
branches:
- main
pull_request_target:
types:
- closed
branches:
- main

permissions:
contents: read
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/use-action.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
name: stale repo identifier

on:
workflow_dispatch:
push:
Expand All @@ -9,10 +8,8 @@ on:
pull_request:
schedule:
- cron: '3 2 1 * *'

permissions:
contents: read

jobs:
build:
name: stale repo identifier
Expand Down

0 comments on commit 67b0908

Please sign in to comment.