-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change includes paths in autobuild.sh #18563
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- actions/extractor/tools/autobuild.sh: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
I recall this was deliberate - as we had an internal convention that additional reusable workflows from other repos could be checked out in some workflows under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @dbartol are you happy with these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a corresponding PowerShell script for Windows machines that needs to be updated as well. I've pushed those changes, but can't add them to this PR because it's from your fork. Just do:
git fetch origin
git merge origin/dbartol/actions-include-pwsh
git push
@dbartol Done |
This PR changes the includes paths to only look at
.github/workflows/*.yml
and.github/workflows/*.yaml
because workflows cannot be nested under subdirectories in.github/workflows
.After further discussion, we've decided to add
to support reusable workflows.
Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).