-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: Support concept id expressions #18366
Draft
jketema
wants to merge
13
commits into
jketema/template-parameters-4
Choose a base branch
from
jketema/template-parameters-5
base: jketema/template-parameters-4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
C++: Support concept id expressions #18366
jketema
wants to merge
13
commits into
jketema/template-parameters-4
from
jketema/template-parameters-5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
This PR should only be merged in sync with an internal Semmle PR
label
Dec 25, 2024
jketema
changed the title
C++: Support concept id expression
C++: Support concept id expressions
Dec 25, 2024
* If the concept id is a type constraint, then `getTemplateArgument(0)` | ||
* will not yield a result. | ||
*/ | ||
final Locatable getTemplateArgument(int index) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
The QLDoc has no documentation for index, but the QLDoc mentions int
* then `getTemplateArgumentKind(1)` yields `int`, and there is no result for | ||
* `getTemplateArgumentKind(0)`. | ||
*/ | ||
final Locatable getTemplateArgumentKind(int index) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
The QLDoc has no documentation for index, but the QLDoc mentions int
jketema
force-pushed
the
jketema/template-parameters-4
branch
3 times, most recently
from
January 3, 2025 20:16
2336e4e
to
c843bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C++
depends on internal PR
This PR should only be merged in sync with an internal Semmle PR
documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).