C#: Update Roslyn nuget dependencies. #18199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we
update_deps.sh
script as this creates a lock file that locks packages to a specific version number. The motivation for this is because we got the compiler warning: GHSA-xhfc-gr8f-ffwc (which is most likely because one of the transitive dependencies is using it).Comments to the updated expected test output.
new()
is correctly extracted.format
test expected output is updated as theparams
keyword is correctly extracted.params
is now supported for a wide range of collection types). https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-13#params-collectionsThere was an issue with the binary log extraction (it could be reproduced outside the extractor). jaredpar/complog#187. This was quickly fixed and a new version of the binlog package is now referenced instead.
DCA:
There doesn't appear to be any performance regressions or changes to the security related alerts, but there is an increase in the number of compilation errors.
I looked into the compiler errors for
dotnet/runtime
anddotnet/roslyn
. It appears that there are two categories of errors.Both of these features are preview features (I checked that preview features are enabled for
dotnet/runtime
). The SHAs of the projects analyzed are pretty old. Roslyn yields compilation errors becausefield
is used within an property accessor (as this references the backing field of the property, when preview features are enabled). https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-13#the-field-keywordInterceptorsNamespaces
instead ofInterceptorsPreviewNamespaces
, which can explain the compiler errors related to interceptors: dotnet/roslyn@5758964#diff-eef9e4c724788e9db96f07567a9894bbb2da020ec59a2ded58b7f22bd175a1a1R223