[GHSA-mwcw-c2x4-8c55] Infinite loop in nanoid #5070
Conversation
github-actions
bot
changed the base branch from
main
to
katzj/advisory-improvement-5070
|
Is the current title not accurate? ai/nanoid#510 seems to indicate that the current title is workable. I can see a desire to expand on the issue, but perhaps that would be better in the description body itself? |
|
It's not an infinite loop in the usual sense of "your program is stuck and runs forever" so this is making the title much more accurate about what the effect is |
|
Not sure I follow, can you help me understand the difference in detail? 👀 |
|
Looks like the bot closed this PR out when I closed #5081 |
|
The issue is that nanoid will generate a predictable id as opposed to the intended secure, unique ids when passed a non-integer size. cc @ai to add any more color |
|
@katzj sounds good. Merge =^_^= |
advisory-database
bot
merged commit 7c8aa24
into
katzj/advisory-improvement-5070
|
Hi @katzj! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
|
Ok. Merged this in but pulled in a bit of issue 510 just for extra context. Let me know if there's anything else 👍 |
Updates
Comments
Make more accurate