-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[view] px단위 rem으로 수정 #751
[view] px단위 rem으로 수정 #751
Conversation
packages/view/src/App.scss
Outdated
} | ||
|
||
.top-container { | ||
height: 220px; | ||
height: 13.75rem; | ||
} | ||
|
||
.middle-container { | ||
display: flex; | ||
height: calc(100vh - 200px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 여기는 혹시 발견 못하신건가요?!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 발견못한 것 같아요..!! 이 부분 추가로 수정하겠습니다 ㅠㅠ
packages/view/src/utils/pxToRem.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍
👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍
👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍
Related issue
#732
Result
pxToRem
함수를 구현해서 계산된 px을 rem으로 바꿔주었습니다.Work list
pxToRem
함수를 만들어서 수정했습니다.Discussion