Update the win+VS build definition #1775
Conversation
|
Invalid author email in 771b341: "49699333+dependabot[bot]@users.noreply.github.com" |
|
There are issues in commit 7fee8dc: |
The main benefit: The new version uses a node.js version that is not yet deprecated. Links: - [Release notes](https://github.com/microsoft/setup-msbuild/releases) - [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md) - [Commits](microsoft/setup-msbuild@v1...v2) This patch was originally by GitHub's Dependabot, but I cannot attribute that bot properly because it has no dedicated email address. Probably because it hasn't reached legal age yet, or something. Signed-off-by: Johannes Schindelin <[email protected]>
The Git for Windows project provides a GitHub Action to download and cache Azure Pipelines artifacts (such as the `vcpkg` artifacts), hiding gnarly internals, and also providing some robustness against network glitches. Let's use it. Signed-off-by: Johannes Schindelin <[email protected]>
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
|
On the Git mailing list, Junio C Hamano wrote (reply to this): "Johannes Schindelin via GitGitGadget" <[email protected]>
writes:
> These two patches have been in Git for Windows' fork for quite a while.
>
> While the win+VS builds are not run in Git's CI builds, it is still a good
> idea to upstream these changes.
>
> Johannes Schindelin (2):
> ci: bump microsoft/setup-msbuild from v1 to v2
> ci(win+VS): download the vcpkg artifacts using a dedicated GitHub
> Action
>
> .github/workflows/main.yml | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
Thanks.
Do you mind if I applied these directly to 'maint' and merged the
result upwards? |
|
On the Git mailing list, Johannes Schindelin wrote (reply to this): Hi Junio,
On Tue, 20 Aug 2024, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <[email protected]>
> writes:
>
> > These two patches have been in Git for Windows' fork for quite a while.
> >
> > While the win+VS builds are not run in Git's CI builds, it is still a good
> > idea to upstream these changes.
> >
> > Johannes Schindelin (2):
> > ci: bump microsoft/setup-msbuild from v1 to v2
> > ci(win+VS): download the vcpkg artifacts using a dedicated GitHub
> > Action
> >
> > .github/workflows/main.yml | 14 +++++---------
> > 1 file changed, 5 insertions(+), 9 deletions(-)
>
> Thanks.
>
> Do you mind if I applied these directly to 'maint' and merged the
> result upwards?
I concur that this is a good idea.
Thank you,
Johannes |
|
This patch series was integrated into seen via git@2f2034f. |
|
On the Git mailing list, Junio C Hamano wrote (reply to this): Johannes Schindelin <[email protected]> writes:
>> Do you mind if I applied these directly to 'maint' and merged the
>> result upwards?
>
> I concur that this is a good idea.
Will, do. Thanks. |
|
This patch series was integrated into maint via git@6a562e6. |
|
This patch series was integrated into seen via git@80ccd8a. |
|
This patch series was integrated into master via git@80ccd8a. |
|
This patch series was integrated into next via git@d252fe9. |
|
Closed via 80ccd8a. |
These two patches have been in Git for Windows' fork for quite a while.
While the win+VS builds are not run in Git's CI builds, it is still a good idea to upstream these changes.