Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack Uploading #5930

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Stack Uploading #5930

merged 2 commits into from
Jan 14, 2025

Conversation

Caleb-T-Owens
Copy link
Contributor

@Caleb-T-Owens Caleb-T-Owens commented Jan 13, 2025 •
edited
Loading

Introduces the new stack publishing protocol.

I've got a small page which shows that the branches do in fact get updated correctly. I've not confirmed that the actual content (IE: the commits) are correctly uploaded, but they should be.

This is part 5 of 6 in a stack made with GitButler:

This was referenced Jan 13, 2025
Merged
Merged
Merged
Merged
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 10:44am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 10:44am

@github-actions github-actions bot added rust Pull requests that update Rust code @gitbutler/desktop labels Jan 13, 2025
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 13, 2025 16:52 Inactive
Base automatically changed from simplify-reflog-code to master January 13, 2025 17:12
@Caleb-T-Owens Caleb-T-Owens force-pushed the newshit branch 2 times, most recently from f098862 to 0f040b2 Compare January 13, 2025 17:17
@Caleb-T-Owens Caleb-T-Owens changed the title wip Stack Uploading Jan 13, 2025
@Caleb-T-Owens Caleb-T-Owens requested a review from krlvi January 13, 2025 17:20
@Caleb-T-Owens Caleb-T-Owens marked this pull request as ready for review January 13, 2025 17:21
estib-vega
estib-vega approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@estib-vega estib-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FE part looks good to me 👍

Just a couple of wild console.logs there :)

apps/desktop/src/lib/history/stackPublishingService.ts Outdated Show resolved Hide resolved
apps/desktop/src/routes/[projectId]/+layout.ts Outdated Show resolved Hide resolved
@Caleb-T-Owens
Copy link
Contributor Author

@Byron I will be adding some tests later, but at the minute the goal is to get an internal prototype out by the end of the week

@Byron
refactor
1602d4e 
- make it a little more idiomatic
- minor changes to help me understand
@Caleb-T-Owens Caleb-T-Owens merged commit ba6f252 into master Jan 14, 2025
21 checks passed
@Caleb-T-Owens Caleb-T-Owens deleted the newshit branch January 14, 2025 12:41
@Caleb-T-Owens Caleb-T-Owens mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estib-vega estib-vega estib-vega approved these changes

@Byron Byron Awaiting requested review from Byron

@krlvi krlvi Awaiting requested review from krlvi

Assignees
No one assigned
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Caleb-T-Owens @estib-vega @Byron