Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite git hooks integration #5895

Open
wants to merge 1 commit into
base: use-index-with-hooks
Choose a base branch
from
Open

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Jan 6, 2025

Iiuc, tools used in pre-commit hooks often rely on files being staged to e.g. only validate hunks being committed. #5735 #2615

  • the typescript side drives the hook runs
  • some very basic tests

*edit: this pr has dramatically changed since it was created.


This is part 3 of 3 in a stack made with GitButler:

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 1:25am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 1:25am

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 6, 2025
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 76ff920 to 4ee4df0 Compare January 6, 2025 22:18
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 4ee4df0 to 140e4ff Compare January 7, 2025 09:44
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 140e4ff to 4309bd1 Compare January 7, 2025 09:57
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 4309bd1 to ee2d78b Compare January 7, 2025 10:54
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from ee2d78b to 51cf919 Compare January 7, 2025 12:07
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 51cf919 to 9b7a7b7 Compare January 9, 2025 23:09
@mtsgrd mtsgrd changed the title Move hooks and staging code into gitbutler-repo Rewrite git hooks integration Jan 9, 2025
@mtsgrd mtsgrd marked this pull request as ready for review January 9, 2025 23:14
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 9b7a7b7 to 06ebdc4 Compare January 10, 2025 00:58
@mtsgrd mtsgrd force-pushed the use-index-with-hooks branch from 06ebdc4 to fb5fd4b Compare January 10, 2025 01:10
- the typescript side drives the hook runs
- some very basic tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant