Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to experimental locking #5339

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Oct 28, 2024

  • changing the name of the field since existing projects would have an explicit false value already

- changing the name of the field since existing projects would have an explicit false value already
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 4:42pm

@mtsgrd
Copy link
Contributor Author

mtsgrd commented Oct 28, 2024

@krlvi in changing the name of the property the old ones that are already explicitly set to false should be dropped, and if I understand correctly this new one should default to true. Wdyt?

@mtsgrd mtsgrd marked this pull request as draft October 28, 2024 16:37
@mtsgrd mtsgrd force-pushed the default-to-experimental-locking branch from 69a1997 to a68e2a2 Compare October 28, 2024 16:37
@mtsgrd mtsgrd force-pushed the default-to-experimental-locking branch from a68e2a2 to e86e210 Compare October 28, 2024 16:42
@mtsgrd mtsgrd marked this pull request as ready for review October 28, 2024 16:42
@krlvi
Copy link
Member

krlvi commented Oct 28, 2024

@krlvi in changing the name of the property the old ones that are already explicitly set to false should be dropped, and if I understand correctly this new one should default to true. Wdyt?

yeah that will make sure that the true gets deployed for everyone

@mtsgrd mtsgrd merged commit 4b77cf4 into master Oct 28, 2024
19 checks passed
@mtsgrd mtsgrd deleted the default-to-experimental-locking branch October 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants