Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add contextMenu to checks and pr btns in StackingPullRequestCard #5285

Merged
merged 5 commits into from
Oct 28, 2024
Merged

feat: add contextMenu to checks and pr btns in StackingPullRequestCard #5285

merged 5 commits into from
Oct 28, 2024

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 23, 2024 •
edited
Loading

☕️ Reasoning

  • Add contextMenu's to PR Card btns

🧢 Changes

  • The checks tag can be right-clicked to reveal "Copy URL" or "Open URL" to jump directly to the checks on GitHub
  • The PR tag can be right-clicked to reveal a "Copy PR Link" option

CC: @PavelLaptev feel free to tweak 👍

image
image

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Oct 28, 2024 0:32am

@ndom91 ndom91 force-pushed the feat-context-menu-pull-request-card-btns branch from 1a24aa2 to 952db13 Compare October 23, 2024 14:54
@ndom91
Copy link
Contributor Author

ndom91 commented Oct 23, 2024

The ../checks URL will only work for GitHub actually :/ so it would be safe for now as that's our only git host, but as soon as we add more this URL might break. Maybe we just drop it here then.

@PavelLaptev PavelLaptev self-requested a review October 25, 2024 11:36
@PavelLaptev
Copy link
Contributor

PavelLaptev commented Oct 25, 2024 •
edited
Loading

@ndom91 I also added reloadPR to the context menu, can you please also check if it works on your side :-)
Because when I click on the "Refetch PR" I don't see any loading states on the PR "checks" tag

@ndom91 ndom91 force-pushed the feat-context-menu-pull-request-card-btns branch from 4476240 to 3c4a5cb Compare October 28, 2024 11:09
@ndom91 ndom91 force-pushed the feat-context-menu-pull-request-card-btns branch from 3c4a5cb to 8ea823c Compare October 28, 2024 12:32
@ndom91 ndom91 enabled auto-merge (rebase) October 28, 2024 12:33
@ndom91 ndom91 merged commit 7a03e89 into master Oct 28, 2024
15 checks passed
@ndom91 ndom91 deleted the feat-context-menu-pull-request-card-btns branch October 28, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelLaptev PavelLaptev PavelLaptev approved these changes

@krlvi krlvi krlvi approved these changes

@mtsgrd mtsgrd mtsgrd approved these changes

Assignees
No one assigned
Labels
@gitbutler/desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndom91 @PavelLaptev @mtsgrd @krlvi