Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in cherry-pick #126

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Conversation

IAmHughes
Copy link

git cherry_pick should be git cherry-pick in the help output. I'm unsure if

cherry_pick: function (args, opt, cmdStr) {
this function needs to be renamed as well, so I wanted to call it out.

If we do change it, then I think we also need to change the README here:

git cherry_pick
(command list at bottom).

@jmegner
Copy link

jmegner commented Jun 26, 2022

I don't think the cherry_pick in controlbox.js needs to change. Running git cherry-pick in the app works just fine. Line 320 takes care of replacing - characters with _ characters in method before this[method] is called on line 328.

@jmegner
Copy link

jmegner commented Jun 26, 2022

This repo's last commit was on 2019-01-30, so it's plausible that the Git School people have moved on. My thanks to them for their wonderful work.

I've forked this repo and merged your commit. It's live. Thanks! I was going to make a similar PR until I saw yours.

I think I'm going to merge in some other PRs, possibly do some of my own work (I haven't yet checked if there's a PR for making current local/remote mode more obvious to the user). I'll probably also try to contact the Git School people and see if they'd be okay with adding a member to help keep this wonderful project active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants