Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust value key filtering in URL sharing #848

Closed
wants to merge 5 commits into from
Closed

fix: adjust value key filtering in URL sharing #848

wants to merge 5 commits into from

Conversation

mguellsegarra
Copy link
Collaborator

  • Added "parent_id" to the allowed values keys in URL parameters
  • Updated useUrlFromCurrentTab to include form values in the actionRawData.
  • Modified RootView to merge filtered values with global values
  • Ensured getPlainValues in Form handles potential null values for getValues and getFields.

@mguellsegarra
fix: adjust value key filtering in URL sharing
9fd9d6a 
- Added "parent_id" to the allowed values keys in URL parameters
- Updated useUrlFromCurrentTab to include form values in the actionRawData.
- Modified RootView to merge filtered values with global values
- Ensured getPlainValues in Form handles potential null values for getValues and getFields.
@mguellsegarra
Copy link
Collaborator Author

He volgut ajustar-ho un pel mes, ara crec que sí que està com toca. També he afegit el parent_id a les keys dels values que deixem passar.

Ho pujo a alpha i la setmana vinent mirem a veure si ho tenim tot estable per passar-ho a v2

@mguellsegarra
fix: improve value merging logic in useUrlFromCurrentTab
1b5d7dd 
- Updated the logic to prioritize form values over action values for non-tree views.
- For tree views with active_ids, merged form values with action values.
- Simplified the final action data structure by directly assigning merged values.
@mguellsegarra
fix: improve and export parameter filtering
c79c3e0
@mguellsegarra
fix: transform initialView to initialViewId
28fff0a
@mguellsegarra
fix: also clear url when closing all tabs
bf072e5
@mguellsegarra
Copy link
Collaborator Author

Crec que ara mateix podem anar tirant amb la versió que ja tenim, he anat apuntant totes les millores aquí 👉 https://github.com/gisce/webclient/issues/1730

@mguellsegarra mguellsegarra deleted the fix/adjustments-in-value-filtering-in-urls branch January 28, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecarreras ecarreras Awaiting requested review from ecarreras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mguellsegarra