Allow to pass precission for every field in Aggregator #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecarreras
changed the title
ecarreras
force-pushed
the
68842/fix-round
branch
from
f938c87 to
befa667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
Aggregatorclass to support precision handling for aggregated fields and updates the corresponding tests to verify this new functionality.Enhancements to Aggregator class:
ooui/helpers/aggregated.py: Added an optionalprecisionsparameter to theAggregatorclass to allow specifying the precision for each field. Updated theprocessmethod to use this precision when performing aggregation functions likesum,count,avg,max, andmin.Updates to tests:
spec/aggregated_spec.py: Added new tests to verify that theAggregatorclass correctly handles precision for fields during aggregation. These tests ensure that the precision is applied correctly for floating-point numbers and that integers are not rounded.