Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set progress to 100 if no jobs provided (Jobspool) #120

Open
wants to merge 2 commits into
base: api_v5
Choose a base branch
from
Open

Set progress to 100 if no jobs provided (Jobspool) #120

wants to merge 2 commits into from

Conversation

polsala
Copy link
Member

@polsala polsala commented Nov 21, 2024

No description provided.

@polsala polsala self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Python oorq redis 5 2.7 Tests for test_oorq

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e84119c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Python oorq redis 3 2.7 Tests for test_oorq

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e84119c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Python oorq redis 7 2.7 Tests for test_oorq

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e84119c.

♻️ This comment has been updated with latest results.

ecarreras
ecarreras reviewed Nov 21, 2024
View reviewed changes
oorq/oorq.py
@@ -93,6 +93,8 @@ def num_jobs(self):

@property
def progress(self):
if not self.num_jobs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crec que s'hauria de posar un and self.joined així assegurem que ja s'ha acabat afegir jobs i evitarrace conditions

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Python oorq redis 3 3.11 Tests for test_oorq

77 tests   77 ✅  36s ⏱️
 2 suites   0 💤
 2 files     0 ❌

Results for commit e84119c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Python oorq redis 7 3.11 Tests for test_oorq

77 tests   77 ✅  36s ⏱️
 2 suites   0 💤
 2 files     0 ❌

Results for commit e84119c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Python oorq redis 5 3.11 Tests for test_oorq

77 tests   77 ✅  36s ⏱️
 2 suites   0 💤
 2 files     0 ❌

Results for commit e84119c.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecarreras ecarreras ecarreras left review comments

@eberloso eberloso Awaiting requested review from eberloso

At least 1 approving review is required to merge this pull request.

Assignees

@polsala polsala

Labels
api_v5 bug to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polsala @ecarreras