Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticket GE21-1796 resolved #94

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

devtechstriker
Copy link
Contributor

No description provided.

@KaitCrawford
Copy link
Contributor

The terms and conditions page can be changed per site so it is defined in the site Profile settings here https://github.com/girleffect/ge-web/blob/main/profiles/models.py#L95
The setting can be referenced in the templates like this https://github.com/girleffect/ge-web/blob/main/profiles/templates/profiles/_patterns/register-form.html#L13

@devtechstriker
Copy link
Contributor Author

Hi @KaitCrawford, I have updated the code according to your suggestions. Please check now.

@KaitCrawford
Copy link
Contributor

@devtechstriker does this work if you run it locally?
I think you'll need to load the wagtailsettings_tags template tags and call one of them. Like this https://github.com/girleffect/ge-web/blob/main/profiles/templates/profiles/_patterns/register-form.html#L1-L2

@devtechstriker
Copy link
Contributor Author

devtechstriker commented Jun 29, 2022

@devtechstriker does this work if you run it locally? I think you'll need to load the wagtailsettings_tags template tags and call one of them. Like this https://github.com/girleffect/ge-web/blob/main/profiles/templates/profiles/_patterns/register-form.html#L1-L2

Yes it was working on my local. But I have check and it's best practice to load the setting as wagtail recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants