Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2790 - supprimer le lien vers le bilan papier dans le mail de bilan adressé au bénéficiaire + wording #2793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −20
Open

#2790 - supprimer le lien vers le bilan papier dans le mail de bilan adressé au bénéficiaire + wording #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion back/src/domains/establishment/use-cases/SendBeneficiariesPdfAssessmentsEmails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ export class SendBeneficiariesPdfAssessmentsEmails extends TransactionalUseCase<
beneficiaryLastName: convention.signatories.beneficiary.lastName,
businessName: convention.businessName,
conventionId: convention.id,
agencyAssessmentDocumentLink: agency.questionnaireUrl ?? undefined,
internshipKind: convention.internshipKind,
},
},
Expand Down
3 changes: 0 additions & 3 deletions back/src/domains/establishment/use-cases/SendBeneficiariesPdfAssessmentsEmails.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ describe("SendBeneficiariesPdfAssessmentsEmails", () => {
conventionEndingTomorrow.signatories.beneficiary.firstName,
businessName: conventionEndingTomorrow.businessName,
internshipKind: conventionEndingTomorrow.internshipKind,
agencyAssessmentDocumentLink:
expectedAgency.questionnaireUrl ?? undefined,
},
recipients: [conventionEndingTomorrow.signatories.beneficiary.email],
sender: {
Expand Down Expand Up @@ -146,7 +144,6 @@ describe("SendBeneficiariesPdfAssessmentsEmails", () => {
beneficiaryFirstName: signatories.beneficiary.firstName,
beneficiaryLastName: signatories.beneficiary.lastName,
conventionId: conventionEndingTomorrow.id,
agencyAssessmentDocumentLink: undefined,
businessName: "my super company",
},
recipients: [signatories.beneficiary.email],
Expand Down
1 change: 0 additions & 1 deletion front/src/app/pages/admin/EmailPreviewTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@ export const defaultEmailValueByEmailKind: {
beneficiaryLastName: "BENEFICIARY_LAST_NAME",
businessName: "BUSINESS_NAME",
internshipKind: "immersion",
agencyAssessmentDocumentLink: "AGENCY_ASSESSMENT_DOCUMENT_LINK",
},
BENEFICIARY_OR_ESTABLISHMENT_REPRESENTATIVE_ALREADY_SIGNED_NOTIFICATION: {
agencyLogoUrl: defaultEmailPreviewUrl,
Expand Down
1 change: 0 additions & 1 deletion shared/src/email/EmailParamsByEmailType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ export type EmailParamsByEmailType = {
beneficiaryLastName: string;
businessName: string;
internshipKind: InternshipKind;
agencyAssessmentDocumentLink: string | undefined;
};
BENEFICIARY_OR_ESTABLISHMENT_REPRESENTATIVE_ALREADY_SIGNED_NOTIFICATION: {
agencyLogoUrl: AbsoluteUrl | undefined;
Expand Down
18 changes: 4 additions & 14 deletions shared/src/email/emailTemplatesByName.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,7 +1044,6 @@ Ne tardez pas : répondez lui directement en utilisant le bouton ci-dessous : `,
beneficiaryLastName,
businessName,
internshipKind,
agencyAssessmentDocumentLink,
}) => ({
subject: `Remplissez le bilan de fin ${
internshipKind === "immersion" ? "d'immersion" : "de mini-stage"
Expand All @@ -1060,20 +1059,11 @@ Ne tardez pas : répondez lui directement en utilisant le bouton ci-dessous : `,
: "mini-stage"
} au sein de l'entreprise ${businessName} est bientôt finie.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} au sein de l'entreprise ${businessName} est bientôt finie.
} au sein de l'entreprise ${businessName} est se termine.


Prenez quelques instants pour remplir le bilan avec votre tuteur. Cela vous servira dans la suite de votre parcours professionnel, que ce soit une formation, une embauche, une découverte de métier. Renvoyez-le ensuite à votre conseiller par email.
Prenez quelques instants avec votre tuteur : il a reçu par mail l'accès au formulaire de bilan qu'il devra compléter en votre présence.
Cela vous servira dans la suite de votre parcours professionnel, que ce soit une formation, une embauche, une découverte de métier.

À la fin de votre immersion, contactez votre conseiller pour faire part de vos impressions et finaliser ainsi votre bilan.
`,
buttons: [
{
label: "Télécharger la fiche bilan",
url:
agencyAssessmentDocumentLink ||
`${
internshipKind === "immersion"
? "https://immersion.cellar-c2.services.clever-cloud.com/bilan-immersion-professionnelle-inscriptible.pdf"
: "https://immersion.cellar-c2.services.clever-cloud.com/CCI_MiniStage_Bilan.pdf"
}`,
},
],
subContent: defaultSignature(internshipKind),
}),
},
Expand Down
Loading