feat(pipeline) : Add raise_for_status #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vperron
added
documentation
vmttn
approved these changes
Nov 15, 2023
Recent versions of Linux all ship Python 3.11 which is out since October 2022. Drop tox's envlist that makes it mandatory to have __that__ version to run the tests. There is very little chance that the few Python tests we have will be sensitive to the version or Python, or we'd be doing some pretty nasty code.
vperron
force-pushed
the
vperron/raise-for-status
branch
from
27d40b5 to
383eab7
Compare
It is not __that__ required for the development process and might be confusing. Assume that "a recent Python version" will work.
py311 is out since a solid year, is the default on almost all recent Linux versions, and it's not very nice to have to hack my environment to downgrade my Python setup (or use pyvenv, or other things) There is very little chance that we break things with this upgrade but we might increase our security and maintanability as some packages might drop Python3.10 someday. Also it will fix a security warning that Scalingo gives us upon deployments: ! A Python security update is available! Upgrade as soon as possible to: python-3.10.12 ! See: https://doc.scalingo.com/languages/python/start
Enables testing the HTTP requests reliably.
Be able to know much sooner when something goes wrong.
vperron
force-pushed
the
vperron/raise-for-status
branch
from
383eab7 to
f0b6b7b
Compare
|
à priori tout est ok sur le staging, on peut merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L'histoire d'une PR qui commence bien, puis je veux ajouter un test, et là je me retrouve à faire une MAJ complète de la version de Python de tous les packages.
Ce qui est de toutes façons une bonne chose, ça nous met à jour, mais bon ^^ Ca résout au passage quelques petits soucis de sécurité.
Les commits sont normalement bien séparés.
Il faudra surveiller un peu plus le déploiement. RAS pour les tests, les images docker, le lancement des DAGs en local, etc.
Cf #145 .