Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and push new container image on merge #54

Closed
wants to merge 1 commit into from

Conversation

asmacdo
Copy link
Contributor

@asmacdo asmacdo commented Feb 15, 2024

  • Rename the test job from "build" for clarity
  • build and push each time a PR merges to main.

@giovtorres, you will need to add secrets for the automation to work.

Once this is up and running, I'm happy to add some release automation as well. Do you have any specific process you'd prefer for that?

@yarikoptic
Copy link

it is tests which are failing
=========================== short test summary info ============================
FAILED tests/test_config.py::test_slurm_var_files[/var/run/slurm/slurmd.pid] - AssertionError: assert False
 +  where False = <file /var/run/slurm/slurmd.pid>.exists
 +    where <file /var/run/slurm/slurmd.pid> = <class 'testinfra.modules.base.GNUFile'>('/var/run/slurm/slurmd.pid')
 +      where <class 'testinfra.modules.base.GNUFile'> = <testinfra.host.Host docker://e878f261087fa82ea23e43587b023c68f2535479722184a128027495ec7da804>.file
FAILED tests/test_config.py::test_slurm_var_files[/var/log/slurm/slurmd.log] - AssertionError: assert False
 +  where False = <file /var/log/slurm/slurmd.log>.exists
 +    where <file /var/log/slurm/slurmd.log> = <class 'testinfra.modules.base.GNUFile'>('/var/log/slurm/slurmd.log')
 +      where <class 'testinfra.modules.base.GNUFile'> = <testinfra.host.Host docker://e878f261087fa82ea23e43587b023c68f2535479722184a128027495ec7da804>.file
FAILED tests/test_config.py::test_slurm_etc_file_owners[/etc/slurm/gres.conf] - AssertionError: assert False
 +  where False = <file /etc/slurm/gres.conf>.exists
 +    where <file /etc/slurm/gres.conf> = <class 'testinfra.modules.base.GNUFile'>('/etc/slurm/gres.conf')
 +      where <class 'testinfra.modules.base.GNUFile'> = <testinfra.host.Host docker://e878f261087fa82ea23e43587b023c68f2535479722184a128027495ec7da804>.file
FAILED tests/test_container.py::test_tini_is_installed - AssertionError: assert '0.18.0' in 'tini version 0.19.0 - git.de40ad0\n'
 +  where 'tini version 0.19.0 - git.de40ad0\n' = CommandResult(backend=<testinfra.backend.docker.DockerBackend object at 0x7ff7421aadc0>, exit_status=0, command=b'/tini --version', _stdout=b'tini version 0.19.0 - git.de40ad0\n', _stderr=b'').stdout
FAILED tests/test_container.py::test_python_is_installed[3.7.12] - AssertionError: assert '' == 'Python 3.7.12'
  
  - Python 3.7.12
FAILED tests/test_container.py::test_python_is_installed[3.8.12] - AssertionError: assert '' == 'Python 3.8.12'
  
  - Python 3.8.12
FAILED tests/test_container.py::test_python_is_installed[3.9.9] - AssertionError: assert '' == 'Python 3.9.9'
  
  - Python 3.9.9
FAILED tests/test_container.py::test_python_is_installed[3.10.0] - AssertionError: assert '' == 'Python 3.10.0'
  
  - Python 3.10.0
FAILED tests/test_container.py::test_slurmd_version - AssertionError: assert '21.08.8' in 'SLURM_VERSION           = 22.05.8\n'
 +  where 'SLURM_VERSION           = 22.05.8\n' = CommandResult(backend=<testinfra.backend.docker.DockerBackend object at 0x7ff7421aadc0>, exit_status=0, command=b'scontrol show config | grep SLURM_VERSION', _stdout=b'SLURM_VERSION           = 22.05.8\n', _stderr=b'').stdout
FAILED tests/test_container.py::test_slurmdbd_is_listening - assert False
 +  where False = <function test_slurmdbd_is_listening.<locals>.<lambda> at 0x7ff741e9de50>()
FAILED tests/test_slurm.py::test_partitions_are_up[debug] - AssertionError: Unexpected exit code 1 for CommandResult(backend=<testinfra.backend.docker.DockerBackend object at 0x7ff7421aadc0>, exit_status=1, command=b'scontrol -o show partition debug', _stdout=b'Partition debug not found\n', _stderr=b'')
assert 1 == 0
 +  where 1 = CommandResult(backend=<testinfra.backend.docker.DockerBackend object at 0x7ff7421aadc0>, exit_status=1, command=b'scontrol -o show partition debug', _stdout=b'Partition debug not found\n', _stderr=b'').rc
FAILED tests/test_slurm.py::test_job_can_run[debug] - RuntimeError: Unexpected output CommandResult(backend=<testinfra.backend.docker.DockerBackend object at 0x7ff7421aadc0>, exit_status=1, command=b'cat -- slurm-.out', _stdout=b'', _stderr=b'cat: slurm-.out: No such file or directory\n')
================== 12 failed, 24 passed in 911.09s (0:15:11) ===================

@asmacdo
Copy link
Contributor Author

asmacdo commented Mar 22, 2024

@giovtorres How would you like to proceed?

@asmacdo
Copy link
Contributor Author

asmacdo commented Jan 21, 2025

IIUC this repo is not continuing development, (to be replaced) so we can close this one

@asmacdo asmacdo closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants