Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gdal dep optional #172

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Conversation

iboates
Copy link
Collaborator

@iboates iboates commented Jan 18, 2025

GDAL can be very cumbersome to install, since it is a Python wrapper to a system binary. That system binary is also notoriously difficult to deal with, as newer versions of Linux (at least Ubuntu) stop adding newer versions to old apt repositories. As a result, it can cause serious headaches with dependency management. It gets even worse when using stricter package management systems, like poetry.

As far as I can tell, this library only actually needs GDAL for one function (create_coveragestyle). This PR removes GDAL from requirements.txt and raises a custom ImportError when the GDAL-specific code is invoked.

BONUS FIX: Apparently the Github action pipelines were failing, too, because the ubuntugis ppa is incompatible with the latest ubuntu version. I pegged the test pipeline to use ubuntu-22.04, it works for now, although it certainly won't stay that way forever.

@iboates iboates assigned iamtekson and unassigned iamtekson Jan 18, 2025
@iboates iboates requested a review from iamtekson January 18, 2025 13:17
Copy link
Collaborator

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Maybe its a good time to update the docs as well. I think we need to inform user about this changes.

Can you please update the documentation how to use.rst file's section "Creating and applying dynamic styles based on the raster coverages"?

Also please update the version number. It should be 2.9

updated docs with mention of newly optional gdal dep
@iboates
Copy link
Collaborator Author

iboates commented Jan 21, 2025

This looks good. Maybe its a good time to update the docs as well. I think we need to inform user about this changes.

Can you please update the documentation how to use.rst file's section "Creating and applying dynamic styles based on the raster coverages"?

Also please update the version number. It should be 2.9

All done!

On the topic of docs, the API docs have been non-functional for quite a while now, as per https://geoserver-rest.readthedocs.io/en/latest/geo.html

@iamtekson iamtekson merged commit ee500d1 into gicait:master Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants