feat: improve resource dialect conversion accuracy #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seia-soto
changed the title
seia-soto
changed the title
2 tasks
| @@ -9,11 +9,11 @@ const createFilter = (rules, filterId = 0) => { | |||
|
|
|||
| export default async function convert(rules, { resourcesPath } = {}) { | |||
| const filter = createFilter(rules.map(normalizeFilter)); | |||
| const conversionResult = await converter.convertStaticRuleSet(filter, { resourcesPath }); | |||
| const conversionResult = await converter.convertStaticRuleSet(filter, { resourcesPath: '/a' }); | |||
There was a problem hiding this comment.
Is the use of "/a" intended here, or should it be using the "resourcesPath" from the arguments?
Update: I assume, it is intended. Perhaps we can give some hint where it originates from (some Adguard convention?). Though I'm not sure where a comment could fit best, since "/a" is also used at other places. I wonder if extracting a constant for it could help?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves redirect resource dialect conversion accuracy by redefining mapping file with multiple dialects. Since we're using AG converter, it's better to convert into AG first then remap output into uBo dialect again for better converage.
The code is written for the numbers of filters in custom filters level. We must optimize the logic to reuse on the backend which processes a lot of filters.