Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Add configurable mount point for secret engines #24

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

ckaipf
Copy link
Contributor

@ckaipf ckaipf commented Mar 4, 2024

Objective

This pull request aims to enhance the functionality by introducing a new configuration parameter, vault_secrets_mount_point. The addition of this parameter will allow users to specify a different mount point for storing secrets, providing greater flexibility and organization within Vault.

Updates

  • Added the vault_secrets_mount parameter to the configuration and pass it to hvac.

@ckaipf ckaipf requested a review from mephenor March 4, 2024 09:21
@ckaipf ckaipf changed the title Add configurable mount point for secret backend Add configurable mount point for secret engines Mar 4, 2024
@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8159085506

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.901%

Totals Coverage Status
Change from base Build 7929396011: 0.1%
Covered Lines: 322
Relevant Lines: 403

💛 - Coveralls

Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing regarding the config option.

Also, this should include at least a minor version bump, but probably even a major one, as changing the mount point is probably not backwards compatible

src/fis/adapters/outbound/vault/client.py Show resolved Hide resolved
@ckaipf ckaipf merged commit d8ea3d8 into main Mar 5, 2024
9 checks passed
@ckaipf ckaipf deleted the feature-add-vault-mount-as-config-param branch March 5, 2024 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants