Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Replaced cumbersome shared generic base class #22

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mephenor
Copy link
Member

No description provided.

with a bit of easier to handle duplication
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7915360063

Details

  • -13 of 63 (79.37%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 80.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/fis/adapters/inbound/fastapi_/routes.py 3 4 75.0%
src/fis/core/ingest.py 24 28 85.71%
src/fis/ports/inbound/ingest.py 21 29 72.41%
Totals Coverage Status
Change from base Build 7903062914: -1.4%
Covered Lines: 309
Relevant Lines: 383

💛 - Coveralls

@TheByronHimes TheByronHimes merged commit b861c49 into feature/current_DI_GSI-615 Feb 15, 2024
9 checks passed
@TheByronHimes TheByronHimes deleted the suggestions/GSI-615 branch February 15, 2024 12:00
TheByronHimes added a commit that referenced this pull request Feb 15, 2024
* Update template files

* Apply new DI strategy

* Update tests

* Update all again and grab new fastapi version

* Update the docs (again)

* Replaced cumbersome shared generic base class (#22)

with a bit of easier to handle duplication

---------

Co-authored-by: TheByronHimes <[email protected]>
Co-authored-by: Thomas Zajac <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants