Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Apply current dependency injection strategy (GSI-615) #21

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

TheByronHimes
Copy link
Member

This applies the big template update and then implements the current DI solution.
FastAPI 0.109.2 is used

@TheByronHimes TheByronHimes requested review from mephenor and Cito and removed request for mephenor February 14, 2024 14:57
@TheByronHimes TheByronHimes marked this pull request as ready for review February 14, 2024 14:58
@TheByronHimes TheByronHimes requested review from mephenor and removed request for Cito February 14, 2024 15:08
with a bit of easier to handle duplication
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7915509142

Details

  • -22 of 128 (82.81%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.2%) to 80.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/fis/adapters/inbound/fastapi_/routes.py 6 7 85.71%
src/fis/core/ingest.py 24 28 85.71%
src/fis/main.py 0 4 0.0%
src/fis/adapters/inbound/fastapi_/configure.py 10 15 66.67%
src/fis/ports/inbound/ingest.py 23 31 74.19%
Files with Coverage Reduction New Missed Lines %
src/fis/main.py 3 0.0%
Totals Coverage Status
Change from base Build 7088414828: -1.2%
Covered Lines: 309
Relevant Lines: 383

💛 - Coveralls

@TheByronHimes TheByronHimes merged commit f708c16 into main Feb 15, 2024
9 checks passed
@TheByronHimes TheByronHimes deleted the feature/current_DI_GSI-615 branch February 15, 2024 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants