Fix check for python version on sc2json script

[manuelseeger]

Python3 deprecates encoding option on json.dumps and defaults to UTF8.

[manuelseeger]

This was nonsense.

Scripts still errors for me though even with the TypeError. Is the executable delivered with the pip package out of date?

[cclauss]

Can you please provide the stack trace for the TypeError?

[manuelseeger]

The existing TypeError check doesn't seem to work since the plugin wrapper doesn't invoke json dumps until after the replay is being loaded in line 41

[manuelseeger]

The TypeError is thrown on factory.load_replay, not on factory.register_plugin, which is being checked.

sc2reader/sc2reader/scripts/sc2json.py

Line 41 in 7da58b1

replay_json = factory.load_replay(args.path[0])

[cclauss]

The TypeError is thrown on factory.load_replay

Can you please provide the stack trace?

[cclauss]

#163 (comment)

[manuelseeger]

Traceback (most recent call last):
File "C:\Users\manuel\dev\sc2reader\sc2reader\scripts\sc2json.py", line 46, in
main()
File "C:\Users\manuel\dev\sc2reader\sc2reader\scripts\sc2json.py", line 41, in main
replay_json = factory.load_replay(args.path[0])
File "c:\users\manuel\dev\sc2reader\sc2reader\factories\sc2factory.py", line 85, in load_replay
return self.load(Replay, source, options, **new_options)
File "c:\users\manuel\dev\sc2reader\sc2reader\factories\sc2factory.py", line 163, in load
return self._load(cls, resource, filename=filename, options=options)
File "c:\users\manuel\dev\sc2reader\sc2reader\factories\sc2factory.py", line 174, in load
obj = plugin(obj)
File "c:\users\manuel\dev\sc2reader\sc2reader\factories\plugins\utils.py", line 17, in call
return func(*args, **opt)
File "c:\users\manuel\dev\sc2reader\sc2reader\factories\plugins\replay.py", line 19, in toJSON
return json.dumps(obj, **options)
File "C:\Users\manuel.conda\envs\sc2reader\lib\json_init.py", line 234, in dumps
return cls(
TypeError: JSONEncoder.init() got an unexpected keyword argument 'encoding'

[cclauss]

This change above is good.
The change below is not really required because the try / except block does the same thing.

[manuelseeger]

If I would leave the original try/except it would throw an AttributeError before the TypeError though if args.encoding doesn't exist

[StoicLoofah]

If python3 doesn't support encoding, should we just drop the encoding option entirely from this command?

[cclauss]

should we just drop the encoding option entirely from this command?

Yes, but we should also drop Python 2… #163 (comment)

[StoicLoofah]

should we just drop the encoding option entirely from this command?

Yes, but we should also drop Python 2… #163 (comment)

You already did a great job clearing out a bunch of Python 2 stuff in this PR #174 Is there more we need to do in the code to drop support, or is it just a config thing?

[cclauss]

@manuelseeger Can you please rebase this pull request or close it?

[cclauss]

As of #174 Python 2 is no longer supported.