feat(uptime): Add uptime-ips endpoint
#84822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
commented
Feb 7, 2025
|
|
||
| class UptimeIpsEndpoint(Endpoint): | ||
| publish_status = { | ||
| "GET": ApiPublishStatus.PRIVATE, |
There was a problem hiding this comment.
would be nice to make public, but it doesn't have a schema since it's not normal JSON
wedamija
approved these changes
Feb 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84822 +/- ##
===========================================
+ Coverage 46.30% 87.56% +41.25%
===========================================
Files 9650 9666 +16
Lines 546450 547120 +670
Branches 21573 21573
===========================================
+ Hits 253029 479073 +226044
+ Misses 293080 67706 -225374
Partials 341 341 |
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-uptime-add-uptime-ips-endpoint
branch
from
43ee8c0 to
bc086e1
Compare
Just hard codes the addresses for now. Later we can have this come from configuration
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-uptime-add-uptime-ips-endpoint
branch
from
bc086e1 to
aa13424
Compare
evanpurkhiser
deleted the
evanpurkhiser/feat-uptime-add-uptime-ips-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just hard codes the addresses for now. Later we can have this come from
configuration