Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anomaly detection): restore correct alert reasons for anomaly detection alerts #84400

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Jan 31, 2025

The code to display anomaly detection alert trigger reasons was removed during a refactor. Restore the code that displays the correct reason. Note: the original code that generates reasons for anomaly detection alerts was introduced in #77331.

Before:
Screenshot 2025-01-31 at 3 36 38 PM

After:
Screenshot 2025-01-31 at 3 36 30 PM

@mifu67 mifu67 requested a review from a team as a code owner January 31, 2025 23:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #84400      +/-   ##
==========================================
- Coverage   87.62%   87.62%   -0.01%     
==========================================
  Files        9615     9615              
  Lines      543662   543661       -1     
  Branches    21334    21334              
==========================================
- Hits       476380   476379       -1     
  Misses      66929    66929              
  Partials      353      353              

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for the fix!

@mifu67 mifu67 merged commit d210118 into master Feb 1, 2025
43 checks passed
@mifu67 mifu67 deleted the mifu67/anomaly-detection-alert-reason-fix branch February 1, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants