Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: copy test_plugins from getsentry #84387

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

asottile-sentry
Copy link
Member

this was not testing anythign in getsentry and makes it difficult to delete a plugin

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #84387   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files        9611     9615    +4     
  Lines      543591   543659   +68     
  Branches    21333    21333           
=======================================
+ Hits       476309   476377   +68     
  Misses      66928    66928           
  Partials      354      354           

this was not testing anythign in getsentry and makes it difficult to delete a plugin
@asottile-sentry asottile-sentry force-pushed the asottile-test-plugins-from-getsentry branch from f3be374 to 9659c1f Compare January 31, 2025 22:21
@asottile-sentry asottile-sentry merged commit 1556384 into master Jan 31, 2025
46 checks passed
@asottile-sentry asottile-sentry deleted the asottile-test-plugins-from-getsentry branch January 31, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants