fix(jira): Add UI for error message when installing in multiple in regions #84377
Conversation
github-actions
bot
added
the
Scope: Backend
|
do you have a screenshot of this change, before and after? |
| @@ -255,16 +255,11 @@ def _finish_pipeline(self, data): | |||
| extra={ | |||
| "organization_id": self.organization.id if self.organization else None, | |||
| "provider_key": self.provider.key, | |||
| "integration_id": self.integration.id, | |||
There was a problem hiding this comment.
Just curious, why do you need to add integration_id here to change the error?
There was a problem hiding this comment.
we don't this addition just makes my life easier to debug when cust are going why can't I install Jira. For example, last week, because our loggers only catch error cases, it was harder to find logs to tell him yo you have Jira already installed in your US org.
|
We discussed in standup because I can't recreate this due to split silo not working on my local, and this was not a high risk change (since self.error) is previously used behavior to just push through. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #84377 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 9611 9611
Lines 543591 543563 -28
Branches 21333 21326 -7
=======================================
- Hits 476309 476308 -1
+ Misses 66928 66901 -27
Partials 354 354 |
Multi-region installs are currently not allowed for the Jira integration. Show an error instead of redirecting without. Also adds integration_id to the logger, so I can match up errors easier.