♻️ ref(slos): change missing access errors to halts for discord #83896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83896 +/- ##
==========================================
- Coverage 87.63% 87.63% -0.01%
==========================================
Files 9522 9523 +1
Lines 542196 542237 +41
Branches 21228 21228
==========================================
+ Hits 475177 475200 +23
- Misses 66653 66671 +18
Partials 366 366 |
cathteng
reviewed
Jan 23, 2025
| if isinstance(error, ApiRateLimitedError): | ||
| # TODO(ecosystem): We should batch this on a per-organization basis | ||
| lifecycle.record_halt(error) | ||
| elif error.code in DISCORD_HALT_ERROR_CODES: |
There was a problem hiding this comment.
Discord returns codes that aren't HTTP status codes?!
| lifecycle.record_halt(e) | ||
| except ApiError as error: | ||
| # Errors that we recieve from the Discord API | ||
| record_lifecycle_termination_level(lifecycle, error) |
There was a problem hiding this comment.
do we need to do this in more places? like anywhere we send a Discord message?
There was a problem hiding this comment.
yep everywhere we send a message, including src/sentry/integrations/discord/actions/metric_alert.py
cathteng
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should mark missing access errors from Discord (which means our bot's access was revoked) as halts instead of failures.
this is inline with what we do with slack here:
sentry/src/sentry/integrations/slack/utils/errors.py
Lines 26 to 27 in 323c6fb