Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow_engine): Endpoint for GET Organization Workflows #83894

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

saponifi3d
Copy link
Contributor

Description

  • Extends the workflow_urls pattern so we can have organization based urls as well
  • Creates a basic GET request handler for /organizations/:slug_or_id/workflows/ to get a list of workflows that an organization has created.
  • Setup scaffolding for the POST handler

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ow_engine/endpoints/organization_workflow_index.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #83894    +/-   ##
========================================
  Coverage   87.61%   87.62%            
========================================
  Files        9525     9528     +3     
  Lines      542401   543068   +667     
  Branches    21258    21258            
========================================
+ Hits       475249   475887   +638     
- Misses      66786    66815    +29     
  Partials      366      366            

@saponifi3d saponifi3d marked this pull request as ready for review January 23, 2025 02:09
@saponifi3d saponifi3d requested review from a team as code owners January 23, 2025 02:09
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits but mostly looks good

owner = ApiOwner.ISSUES

@extend_schema(
operation_id="Fetch a Workflows",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Fetch workflows"?

def setUp(self):
super().setUp()
self.login_as(user=self.user)
self.environment = Environment.objects.create(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is self.environment for here since it's not used? future tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's extra copy pasta 😅 - removing.

@saponifi3d saponifi3d enabled auto-merge (squash) January 23, 2025 17:55
@saponifi3d saponifi3d merged commit 3266f71 into master Jan 23, 2025
48 checks passed
@saponifi3d saponifi3d deleted the jcallender/aci/workflow-api branch January 23, 2025 18:22
andrewshie-sentry pushed a commit that referenced this pull request Jan 29, 2025
# Description
- Extends the `workflow_urls` pattern so we can have organization based
urls as well
- Creates a basic GET request handler for
`/organizations/:slug_or_id/workflows/` to get a list of workflows that
an organization has created.
- Setup scaffolding for the POST handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants