-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflow_engine): Endpoint for GET Organization Workflows #83894
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83894 +/- ##
========================================
Coverage 87.61% 87.62%
========================================
Files 9525 9528 +3
Lines 542401 543068 +667
Branches 21258 21258
========================================
+ Hits 475249 475887 +638
- Misses 66786 66815 +29
Partials 366 366 |
workflow_engine - Update Serialiers to include type & the config attr - Add `get` for OrganizationWorkflows.
…nfig as a pass through
- Add tests for the GET request
58182db
to
fb5ea52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits but mostly looks good
owner = ApiOwner.ISSUES | ||
|
||
@extend_schema( | ||
operation_id="Fetch a Workflows", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "Fetch workflows"?
def setUp(self): | ||
super().setUp() | ||
self.login_as(user=self.user) | ||
self.environment = Environment.objects.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is self.environment
for here since it's not used? future tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's extra copy pasta 😅 - removing.
# Description - Extends the `workflow_urls` pattern so we can have organization based urls as well - Creates a basic GET request handler for `/organizations/:slug_or_id/workflows/` to get a list of workflows that an organization has created. - Setup scaffolding for the POST handler
Description
workflow_urls
pattern so we can have organization based urls as well/organizations/:slug_or_id/workflows/
to get a list of workflows that an organization has created.