Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uptime): Add enable/disable project subscription methods #83893

Conversation

evanpurkhiser
Copy link
Member

We'll use these methods when enabling / disabling a uptime monitor for
seat quota reasons

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner January 23, 2025 01:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/uptime/subscriptions/subscriptions.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #83893      +/-   ##
==========================================
- Coverage   87.63%   87.63%   -0.01%     
==========================================
  Files        9522     9522              
  Lines      542196   542253      +57     
  Branches    21228    21228              
==========================================
+ Hits       475177   475218      +41     
- Misses      66653    66669      +16     
  Partials      366      366              

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. We'll need a filter in the result consumer to ignore results for projects with disabled status, for the cases where the uptime subscription is shared

@evanpurkhiser evanpurkhiser merged commit b664da0 into master Jan 23, 2025
50 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-uptime-add-enable-disable-project-subscription-methods branch January 23, 2025 22:14
@evanpurkhiser
Copy link
Member Author

Here's the follow up for that #83950

andrewshie-sentry pushed a commit that referenced this pull request Jan 29, 2025
We'll use these methods when enabling / disabling a uptime monitor for
seat quota reasons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants